feat: implement SSH server - #3
Closed
loris-catalano wants to merge 1 commit into
Closed
Conversation
moakilodash
reviewed
Apr 9, 2026
| use crossterm::{ | ||
| event::{self, Event, KeyCode, KeyModifiers}, | ||
| execute, | ||
| terminal::{disable_raw_mode, enable_raw_mode, EnterAlternateScreen, LeaveAlternateScreen}, |
Member
There was a problem hiding this comment.
why did you rewrite the whole thing lol
moakilodash
reviewed
Apr 9, 2026
| use crate::app::{terminal_for_ssh, App}; | ||
|
|
||
| /// Async bridge: crossterm writes are batched on `flush` and sent on the SSH channel. | ||
| /// Pattern from russh `examples/ratatui_app.rs`. |
Member
There was a problem hiding this comment.
the was no examples with this pr
Member
other than that this looks good to me, resolve the mentioned critiques, and open a new pr against that branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces SSH server support, enabling users to connect to the shopping TUI over SSH. It adds SSH server implementation, handles persistent Ed25519 host key management, and updates documentation and dependencies accordingly. The changes are grouped below by theme.
SSH Server Implementation:
src/ssh_server.rswith a full SSH server implementation usingrussh, including per-session TUI spawning, PTY handling, and proper session lifecycle management.Host Key Management:
src/host_key.rsto load or generate a persistent Ed25519 SSH host key in OpenSSH format, ensuring secure and repeatable server identity.Dependency Updates:
Cargo.tomlto add dependencies for SSH support (russh,tokio,anyhow,bytes).Documentation:
README.mdwith instructions for running the SSH server, connecting via SSH, and using the local TUI mode.ROADMAP.mdto mark the SSH server phase as complete, reflecting the new SSH capabilities.